Skip to content

Updated origin pill component to match the new design#15603

Merged
brad-decker merged 2 commits intodevelopfrom
update-origin-pill
Aug 24, 2022
Merged

Updated origin pill component to match the new design#15603
brad-decker merged 2 commits intodevelopfrom
update-origin-pill

Conversation

@VSaric
Copy link
Copy Markdown
Contributor

@VSaric VSaric commented Aug 16, 2022 •
edited
Loading

Explanation

Updated origin pill component to match the new design.

More Information

Screenshots/Screencaps

Before

Confirmation screen (test-dapp):

Screenshot 2022-08-16 at 14 36 20

Screenshot 2022-08-16 at 14 37 40

Confirmation screen (switching networks) - Uniswap:

Screenshot 2022-08-16 at 14 34 31

Confirmation screen (switching networks) - ChainList:

Screenshot 2022-08-16 at 14 35 30

After

Confirmation screen (test-dapp):

Screenshot 2022-08-16 at 11 25 31

Screenshot 2022-08-16 at 11 23 52

Confirmation screen (switching networks) - Uniswap:

Screenshot 2022-08-16 at 11 26 25

Confirmation screen (switching networks) - ChainList:

Screenshot 2022-08-16 at 11 27 05

Manual Testing Steps

Confirmation screen (test-dapp):

  1. Unlock Metamask
  2. Connect account in test-dapp
  3. Click CREATE TOKEN button
  4. Click APPROVE TOKENS or APPROVE TOKENS WITHOUT GAS button

Confirmation screen (switching networks) - Uniswap:

  1. Unlock Metamask
  2. Go to https://uniswap.org/ and click Launch App button
  3. Click on dropdown where the network is
  4. Select a network

Confirmation screen (switching networks) - ChainList:

  1. Unlock Metamask
  2. Go to https://chainlist.org/ and click Connect Wallet button
  3. Click Add To Metamask button
  4. Click Approve button

@VSaric VSaric self-assigned this Aug 16, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 16, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 16, 2022

Builds ready [3f8ad45]
Page Load Metrics (1790 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint913671195728
domContentLoaded16242199176912660
load16242199179013062
domInteractive16242199176912660

highlights:

storybook

@mirjanaKukic
Copy link
Copy Markdown
Contributor

mirjanaKukic commented Aug 17, 2022

Verified by QA

@VSaric VSaric marked this pull request as ready for review August 17, 2022 09:53
@VSaric VSaric requested a review from a team as a code owner August 17, 2022 09:53
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 18, 2022

Builds ready [dace89a]
Page Load Metrics (1767 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint88144113189
domContentLoaded15632004174911555
load15642022176712660
domInteractive15632004174911555

highlights:

storybook

@VSaric VSaric requested a review from NidhiKJha August 19, 2022 07:50
@brad-decker brad-decker merged commit 9a359b8 into develop Aug 24, 2022
@brad-decker brad-decker deleted the update-origin-pill branch August 24, 2022 16:02
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NiranjanaBinoy NiranjanaBinoy Awaiting requested review from NiranjanaBinoy NiranjanaBinoy is a code owner automatically assigned from MetaMask/extension-devs

@danjm danjm Awaiting requested review from danjm

@NidhiKJha NidhiKJha Awaiting requested review from NidhiKJha

@georgewrmarshall georgewrmarshall Awaiting requested review from georgewrmarshall

2 more reviewers

@darkwing darkwing darkwing approved these changes

@brad-decker brad-decker brad-decker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@VSaric VSaric

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update origin pill component to match the new design

5 participants

@VSaric @metamaskbot @mirjanaKukic @darkwing @brad-decker