Skip to content

ci - improve lavamoat validation debug info#12259

Merged
kumavis merged 3 commits intodevelopfrom
ci-validate-lavamoat-policies
Oct 1, 2021
Merged

ci - improve lavamoat validation debug info#12259
kumavis merged 3 commits intodevelopfrom
ci-validate-lavamoat-policies

Conversation

@kumavis
Copy link
Copy Markdown
Member

@kumavis kumavis commented Sep 30, 2021

No description provided.

@kumavis kumavis requested a review from a team as a code owner September 30, 2021 23:02
@kumavis kumavis requested review from Gudahtt and danjm September 30, 2021 23:02
@kumavis kumavis mentioned this pull request Sep 30, 2021
Merged
3 tasks
darkwing
darkwing previously approved these changes Sep 30, 2021
View reviewed changes
rekmarks
rekmarks reviewed Sep 30, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason to narrow the git diff invocations to just package.json and lavamoat/? It seems more future proof to not specify a file or path, at no cost to readability.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 30, 2021

Builds ready [e8c3595]
Page Load Metrics (333 ± 35 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint925683158842
domContentLoaded2505523147134
load2655693337235
domInteractive2505523147134

@kumavis
Copy link
Copy Markdown
Member Author

kumavis commented Sep 30, 2021

the validations deal with specifically those targets, we could add a more generic check i suppose

@kumavis
Copy link
Copy Markdown
Member Author

kumavis commented Sep 30, 2021

i also limited the diff to ensure the validation debug output was relevant

Gudahtt
Gudahtt previously approved these changes Oct 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

brad-decker
brad-decker previously approved these changes Oct 1, 2021
View reviewed changes
@kumavis kumavis dismissed stale reviews from brad-decker, Gudahtt, and darkwing via 3c7d104 October 1, 2021 18:54
rekmarks
rekmarks approved these changes Oct 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 1, 2021

Builds ready [b7accee]
Page Load Metrics (296 ± 16 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint513242498239
domContentLoaded2353552783316
load2453702963416
domInteractive2353552783316

@kumavis kumavis merged commit a174d50 into develop Oct 1, 2021
@kumavis kumavis deleted the ci-validate-lavamoat-policies branch October 1, 2021 19:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@rekmarks rekmarks rekmarks approved these changes

@danjm danjm Awaiting requested review from danjm danjm was automatically assigned from MetaMask/extension-devs

+2 more reviewers

@darkwing darkwing darkwing left review comments

@brad-decker brad-decker brad-decker left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kumavis @metamaskbot @darkwing @Gudahtt @brad-decker @rekmarks