Skip to content

lockdown - breakout making globalThis properties non-writable#12258

Merged
kumavis merged 3 commits intodevelopfrom
lockdown-more
Oct 1, 2021
Merged

lockdown - breakout making globalThis properties non-writable#12258
kumavis merged 3 commits intodevelopfrom
lockdown-more

Conversation

@kumavis
Copy link
Copy Markdown
Member

@kumavis kumavis commented Sep 30, 2021

this is in preperation for using LavaMoat which does lockdown-run.js but not lockdown-more.js

@kumavis kumavis requested review from Gudahtt and rekmarks September 30, 2021 22:45
@kumavis kumavis requested a review from a team as a code owner September 30, 2021 22:45
@kumavis kumavis mentioned this pull request Sep 30, 2021
Merged
3 tasks
darkwing
darkwing reviewed Sep 30, 2021
View reviewed changes
@darkwing
Copy link
Copy Markdown
Contributor

darkwing commented Sep 30, 2021

Naming is difficult but could we make -more more specific? I guess I don't have a better word off the top of my head :/

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 30, 2021

Builds ready [bf6f151]
Page Load Metrics (339 ± 26 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint595113177938
domContentLoaded2734983195225
load2885223395426
domInteractive2734983195225

rekmarks
rekmarks requested changes Sep 30, 2021
View reviewed changes
@rekmarks
Copy link
Copy Markdown
Member

rekmarks commented Sep 30, 2021 •
edited
Loading

@darkwing @kumavis how about lockdown-intrinsics instead of lockdown-more?

Edit: or lockdown-all-intrinsics.

kumavis and others added 2 commits September 30, 2021 13:29
@kumavis @darkwing
Update app/scripts/lockdown-more.js
27bed6a 
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
@kumavis @rekmarks
Update app/scripts/lockdown-more.js
c7bd12c 
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
@kumavis
Copy link
Copy Markdown
Member Author

kumavis commented Sep 30, 2021

i definitely struggled to find an appropriate name

@kumavis
Copy link
Copy Markdown
Member Author

kumavis commented Sep 30, 2021

we also considered expanding this beyond intrinsics

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 1, 2021

Builds ready [c7bd12c]
Page Load Metrics (292 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5447923311555
domContentLoaded2324682765426
load2494852925727
domInteractive2324682765426

rekmarks
rekmarks approved these changes Oct 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Gudahtt
Gudahtt approved these changes Oct 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kumavis kumavis merged commit f9ea9e4 into develop Oct 1, 2021
@kumavis kumavis deleted the lockdown-more branch October 1, 2021 18:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@rekmarks rekmarks rekmarks approved these changes

+2 more reviewers

@darkwing darkwing darkwing left review comments

@ryanml ryanml ryanml approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kumavis @darkwing @metamaskbot @rekmarks @Gudahtt @ryanml