Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
f1584de to
ba4d549
Compare
tmashuang
previously approved these changes
Sep 24, 2021
Collaborator
Builds ready [ba4d549]
Page Load Metrics (296 ± 23 ms)
highlights: |
mcmire
previously approved these changes
Sep 24, 2021
Contributor
mcmire
left a comment
There was a problem hiding this comment.
One little comment, but otherwise looks good.
ui/hooks/useTokenFiatAmount.js
Outdated
Comment on lines
37
to
42
Contributor
There was a problem hiding this comment.
Instead of representing "not found" with contractExchangeTokenKey[''], would it be more accurate to say this? Also would it be more clear to represent the key as key rather than i?
Suggested change
| const contractExchangeTokenKey = | |
| Object.keys(contractExchangeRates).find((i) => | |
| isEqualCaseInsensitive(i, tokenAddress), | |
| ) || ''; | |
| const tokenExchangeRate = | |
| overrides.exchangeRate ?? contractExchangeRates[tokenAddress]; | |
| overrides.exchangeRate ?? contractExchangeRates[contractExchangeTokenKey]; | |
| const contractExchangeTokenKey = | |
| Object.keys(contractExchangeRates).find((key) => | |
| isEqualCaseInsensitive(key, tokenAddress), | |
| ); | |
| const tokenExchangeRate = | |
| overrides.exchangeRate ?? (contractExchangeTokenKey && | |
| contractExchangeRates[contractExchangeTokenKey]); |
Contributor
Author
There was a problem hiding this comment.
Yeah that makes sense!
ba4d549 to
88eb810
Compare
Collaborator
Builds ready [88eb810]
Page Load Metrics (306 ± 11 ms)
highlights: |
mcmire
approved these changes
Sep 24, 2021
tmashuang
approved these changes
Sep 27, 2021
jpuri
approved these changes
Sep 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2 in 10.2.0 RC issues doc