Keep ENS name in the URL when redirecting IPFS and IPNS content#11520
Keep ENS name in the URL when redirecting IPFS and IPNS content#11520AlicanC wants to merge 2 commits intoMetaMask:developfrom
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
|
Thanks for the contribution @AlicanC, we will review soon |
Interesting - I wasn't aware that this was a thing that IPFS gateways could do. Do you know of any documentation about this feature? Can we expect all or most IPFS gateways to behave similarly? |
Not that I know of. I discovered this by accident.
Last time I took a deep dive was months ago but IPFS gateways behaving similarly wasn't a thing in general 😄 I wouldn't depend on it but YMMV. |
|
@AlicanC has your understanding of this expanded any since your first submission? If there is any documentation about this feature now that you can share that would greatly expedite review process. IF not we will dig in soon. I just updated the PR to see if tests are still green. |
|
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions. |
|
This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions. |
This is another take on #7740.
When a user visits "myname.eth" what we are doing right now is:
typeandhash.typeis "ipfs-ns" (or "ipns-ns"), redirect tohttps://[hash].ipfs.gateway(orhttps://[hash].ipns.gateway).With the changes in this PR, we will instead redirect to
https://myname-eth.ipns.gateway/(for both "ipfs-ns" and "ipns-ns") which will keep the ENS name in the URL. (Resolvingmyname.ethto its actual "ipfs-ns"/"ipns-ns" content will be done by the gateway for us.)Manual testing steps: