Fix 10609 - Prevent overflow of confirmation page hostname#10935
Merged
darkwing merged 1 commit intoMetaMask:developfrom Apr 27, 2021
Merged
Fix 10609 - Prevent overflow of confirmation page hostname#10935darkwing merged 1 commit intoMetaMask:developfrom
darkwing merged 1 commit intoMetaMask:developfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10609
Explanation: Presently a long hostname on the confirmation screen can take make the window stretch beyond its width. I've updated the design to keep screen width integrity and wrap the hostname so the user can always see that full text.
Shout out to @brad-decker for the CSS wizardry ideas.