Skip to content

upgrade eth-keyring-controller#10933

Merged
brad-decker merged 1 commit intodevelopfrom
upgrade-keyring
Apr 27, 2021
Merged

upgrade eth-keyring-controller#10933
brad-decker merged 1 commit intodevelopfrom
upgrade-keyring

Conversation

@brad-decker
Copy link
Copy Markdown
Contributor

@brad-decker brad-decker commented Apr 26, 2021

Supports newer versions of @ethereumjs/tx in HD and simple keyring types, while maintaining backwards compatibility.

Required two changes to tests:

  1. _privKey and _pubKey are replaced by privateKey and publicKey
  2. The error message for messages of incorrect length has been updated (I can't find this change in the dependencies so it must be a transient dependency update)

@brad-decker brad-decker requested a review from a team as a code owner April 26, 2021 21:29
@brad-decker brad-decker requested a review from darkwing April 26, 2021 21:29
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [920feb2]
Page Load Metrics (639 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint50816484
domContentLoaded3907636379545
load3927646399545
domInteractive3907626379545

Copy link
Copy Markdown
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brad-decker brad-decker merged commit cbce07e into develop Apr 27, 2021
@brad-decker brad-decker deleted the upgrade-keyring branch April 27, 2021 17:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants