add view account-details menu item to token-options menu#10932
add view account-details menu item to token-options menu#10932adonesky1 merged 2 commits intoMetaMask:developfrom
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
@danjm Just want to highlight here there are segment events that are raised by the click handlers of the base account level menu items. Not sure if there is an existing issue to port those over to these asset-level menus, but if not I'm happy to write one up? |
brad-decker
left a comment
There was a problem hiding this comment.
LGTM. We could probably just invoke dispatch(showModal directly from the token-options component but given these two files are already linked tightly it doesn't matter and your contribution matches what is already happening so I think we should land it as is.
|
Oops missed the proptypes. Just need to update those and I think this can land |
(partially) Fixes: #10148
Explanation: Adds the Account Details menu item/link to the hamburger menu on token pages
Manual testing steps: