Merged
Conversation
Collaborator
Builds ready [1f6683b]
Page Load Metrics (596 ± 36 ms)
|
shanejonas
reviewed
Apr 22, 2021
shanejonas
reviewed
Apr 22, 2021
rekmarks
approved these changes
May 10, 2021
Comment on lines
+56
to
+62
| if (!isSafeChainId(parseInt(_chainId, 16))) { | ||
| return end( | ||
| ethErrors.rpc.invalidParams({ | ||
| message: `Invalid chain ID "${_chainId}": numerical value greater than max safe value. Received:\n${chainId}`, | ||
| }), | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
I don't think this check is necessary for the purposes of this method, but it's nice from a "fail early and often" perspective.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements basic swithEthereumChain feature for suggesting a user to switch to a specified chain that they already have added to MetaMask. This method will work with default networks like mainnet.