Skip to content

Use jest to run ui/**/*.test.js#10885

Merged
tmashuang merged 1 commit intodevelopfrom
jest-ui
Apr 15, 2021
Merged

Use jest to run ui/**/*.test.js#10885
tmashuang merged 1 commit intodevelopfrom
jest-ui

Conversation

@tmashuang
Copy link
Contributor

@tmashuang tmashuang commented Apr 14, 2021

Large PR to change the ui/'s tests runner to jest.

@tmashuang tmashuang requested a review from a team as a code owner April 14, 2021 21:46
@tmashuang tmashuang requested a review from ryanml April 14, 2021 21:46
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brad-decker
Copy link
Contributor

🚀 🎸 🤘🏻

Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to do a more thorough review soon, but wanted to say that from a surface level this looks great. Number of tests match up good so I don't think we're missing anything. long live the reign of jest.

@tmashuang
Copy link
Contributor Author

tmashuang commented Apr 14, 2021

There are still some inconsistencies such as, we are still using enzyme as out component wrappers and sinon for some stubbing. Here I used jest.fn() over sinon in some places that it seemed appropriate and replaced proxyquire with jest.mock. As I didn't want to complicate the PR too too much with the nuanced differences between jest.fn() and sinon that can be migrated in a different PR, as well as the migration from Enzyme to testing-library/react.

Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, excited to get coverage minimums and path for ward for UI test coverage

@tmashuang tmashuang merged commit b99c4fb into develop Apr 15, 2021
@tmashuang tmashuang deleted the jest-ui branch April 15, 2021 18:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants