Fix 10036 - Prevent odd localStorage migration error in Firefox#10884
Merged
darkwing merged 1 commit intoMetaMask:developfrom Apr 14, 2021
Merged
Fix 10036 - Prevent odd localStorage migration error in Firefox#10884darkwing merged 1 commit intoMetaMask:developfrom
darkwing merged 1 commit intoMetaMask:developfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
approved these changes
Apr 14, 2021
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM!
I too have noticed that the compatibility tables on MDN for some APIs seem to contradict the Sentry errors we get.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10036
Explanation:
This is a weird one -- the only hint I can find is: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Privacy/Storage_access_policy, though it cites the error having been removed in Firefox 70, yet we're seeing the error happen in up to Firefox 84.
That said, we've only seen this happen 16 times in Firefox since January 2021, and it's for a "cleanup" migration with no other side effect than old cached data in a structure we're no longer using.
I think a
window.localStoragecheck here would suffice.