Skip to content

Add jest coverage#10868

Merged
tmashuang merged 2 commits intodevelopfrom
jest-coverage
Apr 9, 2021
Merged

Add jest coverage#10868
tmashuang merged 2 commits intodevelopfrom
jest-coverage

Conversation

@tmashuang
Copy link
Copy Markdown
Contributor

This will add coverage for any tests ran in jest under the test:coverage:jest command, which is currently being used in CI. I set the values to the current test coverage in ui/app/pages/swaps.

This will add coverage for any tests ran in jest under the `test:coverage:jest` command, which is currently being used in CI. I set the values to the current test coverage in `ui/app/pages/swaps`.
@tmashuang tmashuang requested a review from a team as a code owner April 9, 2021 19:33
@tmashuang tmashuang requested a review from Gudahtt April 9, 2021 19:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [b7cf2fc]
Page Load Metrics (675 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint489766136
domContentLoaded4458676749847
load4478686759847
domInteractive4458666739847

@tmashuang tmashuang merged commit b7ee97c into develop Apr 9, 2021
@tmashuang tmashuang deleted the jest-coverage branch April 9, 2021 20:10
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants