Skip to content

Quote globs in prettier scripts#10867

Merged
rekmarks merged 1 commit intodevelopfrom
fix-prettier-scripts
Apr 13, 2021
Merged

Quote globs in prettier scripts#10867
rekmarks merged 1 commit intodevelopfrom
fix-prettier-scripts

Conversation

@rekmarks
Copy link
Copy Markdown
Member

@rekmarks rekmarks commented Apr 9, 2021

The globs in our Prettier scripts should be quoted. This PR ensures that they are.

Don’t forget the quotes around the globs! The quotes make sure that Prettier CLI expands the globs rather than your shell, which is important for cross-platform usage.

https://prettier.io/docs/en/cli.html

@rekmarks rekmarks requested a review from a team as a code owner April 9, 2021 19:19
@rekmarks rekmarks requested a review from danjm April 9, 2021 19:19
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit 7fb4e09 into develop Apr 13, 2021
@rekmarks rekmarks deleted the fix-prettier-scripts branch April 13, 2021 17:40
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants