Merged
Conversation
16b7c55 to
bb92c30
Compare
brad-decker
reviewed
Apr 8, 2021
| primary: PropTypes.string, | ||
| secondary: PropTypes.string, | ||
| identiconBorder: PropTypes.bool, | ||
| 'iconClassName': PropTypes.string, |
Contributor
There was a problem hiding this comment.
is it too late for me to hate this? 😆
Member
Author
There was a problem hiding this comment.
We're accepting PRs over at https://github.com/MetaMask/eslint-config
brad-decker
approved these changes
Apr 8, 2021
Contributor
brad-decker
left a comment
There was a problem hiding this comment.
other than the rule thing I commented on this looks dope. I can learn to not hate the rule, if it changes it for me on save 😂
Collaborator
Builds ready [3d983a2]
Page Load Metrics (673 ± 53 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@metamask/eslint-config@6.0.0@metamask/eslint-config-mocha@6.0.0@metamask/eslint-config-nodejs@6.0.0.eslintrc.jsper new configs (base config includes prettier)yarn lint:fixClean run:
Cached run:
😎