Skip to content

Adjust renderWithProvider to accommodate redux-less components#10857

Merged
tmashuang merged 1 commit intodevelopfrom
expand-render-helpers
Apr 9, 2021
Merged

Adjust renderWithProvider to accommodate redux-less components#10857
tmashuang merged 1 commit intodevelopfrom
expand-render-helpers

Conversation

@tmashuang
Copy link
Contributor

This adds a conditional to the renderWithProvider() render components that aren't connected to the store to render without the Provider and Router.

@tmashuang tmashuang requested a review from a team as a code owner April 8, 2021 20:34
@tmashuang tmashuang requested a review from shanejonas April 8, 2021 20:34
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [c278738]
Page Load Metrics (526 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44695484
domContentLoaded29963952411455
load30164052611354
domInteractive29963952411455

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmashuang tmashuang merged commit f7f1f28 into develop Apr 9, 2021
@tmashuang tmashuang deleted the expand-render-helpers branch April 9, 2021 15:59
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants