Skip to content

Migrate unreleased changes in changelog#10853

Merged
Gudahtt merged 1 commit intodevelopfrom
migrate-unreleased-changelog-entries
Apr 8, 2021
Merged

Migrate unreleased changes in changelog#10853
Gudahtt merged 1 commit intodevelopfrom
migrate-unreleased-changelog-entries

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Apr 8, 2021

When updating the changelog for a release candidate, any unreleased changes are now migrated to the release header.

Generally we don't make a habit of adding changes to the changelog prior to creating a release candidate, but if any are there we certainly don't want them duplicated.

Relates to #10752

Manual testing steps:

  • Run yarn update-changelog to add unreleased changes
  • See that changes have been added to the "Unreleased" header
  • Run yarn update-changelog --rc
  • See that it has migrated everything to the v9.3.0 header.
    • Note that any commits without a PR number in the description are duplicated. This is a pre-existing issue, as our duplication detection relies upon the PR number. This will be prevented in the future by mandating GitHub Squash & Merge as the only allowed strategy, which will ensure that a PR number is present in the commit message.

When updating the changelog for a release candidate, any unreleased
changes are now migrated to the release header.

Generally we don't make a habit of adding changes to the changelog
prior to creating a release candidate, but if any are there we
certainly don't want them duplicated.
@Gudahtt Gudahtt requested review from a team and kumavis as code owners April 8, 2021 18:57
@Gudahtt Gudahtt requested a review from danjm April 8, 2021 18:57
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [3678692]
Page Load Metrics (627 ± 28 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint47866294
domContentLoaded4066936265928
load4076946275928
domInteractive4066936265928

Copy link
Copy Markdown
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is pretty straightforward. Output looks good to me 👍🏻

@Gudahtt Gudahtt merged commit e77aa0b into develop Apr 8, 2021
@Gudahtt Gudahtt deleted the migrate-unreleased-changelog-entries branch April 8, 2021 20:23
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants