Add validation for the fee property from the /trades API response#10836
Merged
danjm merged 1 commit intoMetaMask:developfrom Apr 7, 2021
dan437:trades-fee-validation
Merged
Add validation for the fee property from the /trades API response#10836danjm merged 1 commit intoMetaMask:developfrom dan437:trades-fee-validation
fee property from the /trades API response#10836danjm merged 1 commit intoMetaMask:developfrom
dan437:trades-fee-validation
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9681
Explanation
Now we are validating that the
feeproperty from the/tradesAPI response is thenumbertype. If the API would return a different type, we would show an error page with: "No quotes available".Manual testing steps
Swapbutton inside the MetaMask extensionSwap fromandSwap totokensReview Swap, at which time the/tradesAPI is called and response validation happensScreenshots
Swap page:
feevalidation passed and a user can see the Swap Review page:feeproperty in the/tradesAPI response:"No quotes available" page would be displayed if the type validation fails (e.g. when we would expect an object instead of number):
All unit are tests green:
