Skip to content

Removing unnecessary params from withFixtures function call.#10831

Merged
NiranjanaBinoy merged 1 commit intodevelopfrom
remove-dapp-withfixtures
Apr 6, 2021
Merged

Removing unnecessary params from withFixtures function call.#10831
NiranjanaBinoy merged 1 commit intodevelopfrom
remove-dapp-withfixtures

Conversation

@NiranjanaBinoy
Copy link
Copy Markdown
Contributor

Removing the dapp=true parameter from withFixtures function call on the tests that are not using the Dapp.

@NiranjanaBinoy NiranjanaBinoy requested a review from Gudahtt April 6, 2021 15:11
@NiranjanaBinoy NiranjanaBinoy self-assigned this Apr 6, 2021
@NiranjanaBinoy NiranjanaBinoy requested a review from a team as a code owner April 6, 2021 15:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [addb2c3]
Page Load Metrics (635 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint4710164136
domContentLoaded39494863313967
load39694963513967
domInteractive39494763313967

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@NiranjanaBinoy NiranjanaBinoy merged commit dc1a036 into develop Apr 6, 2021
@NiranjanaBinoy NiranjanaBinoy deleted the remove-dapp-withfixtures branch April 6, 2021 17:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants