Refactoring permissions.spec.js to use fixtures#10829
Merged
NiranjanaBinoy merged 2 commits intodevelopfrom Apr 6, 2021
Merged
Refactoring permissions.spec.js to use fixtures#10829NiranjanaBinoy merged 2 commits intodevelopfrom
NiranjanaBinoy merged 2 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [62d1b6c]
Page Load Metrics (758 ± 46 ms)
|
Gudahtt
previously approved these changes
Apr 6, 2021
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! One leftover comment to get rid of - I can re-approve after that is removed.
test/e2e/tests/permissions.spec.js
Outdated
| By.xpath(`//button[contains(text(), 'Connect')]`), | ||
| ); | ||
|
|
||
| // await driver.waitUntilXWindowHandles(2); |
Member
There was a problem hiding this comment.
Nit: Leftover comment from development it looks like
Suggested change
| // await driver.waitUntilXWindowHandles(2); |
Gudahtt
approved these changes
Apr 6, 2021
Collaborator
Builds ready [3901414]
Page Load Metrics (554 ± 51 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10828
Explanation: