Fix _getPermittedAccounts type safety#10819
Merged
Conversation
Collaborator
Builds ready [ce2f5ad]
Page Load Metrics (601 ± 63 ms)
|
darkwing
approved these changes
Apr 5, 2021
Contributor
darkwing
left a comment
There was a problem hiding this comment.
I very, very much like this change! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PermissionsController._getPermittedAccountscould return an array ornull, but it was used inremoveAllAccountPermissionsas though it could only return an array.I don't believe it would ever return anything other than an array as things stand, but it's not type safe, and we should fix it. Things with
getAccountsin the name tend to only return arrays in our codebase, so I made_getPermittedAccountsonly return arrays, and updated calls expectingnullto expect an empty array instead.