Skip to content

Move BSC chain ID, rename some BSC-related vars#10807

Merged
darkwing merged 1 commit intoMetaMask:developfrom
darkwing:bsc-constants
Apr 7, 2021
Merged

Move BSC chain ID, rename some BSC-related vars#10807
darkwing merged 1 commit intoMetaMask:developfrom
darkwing:bsc-constants

Conversation

@darkwing
Copy link
Contributor

@darkwing darkwing commented Apr 2, 2021

Explanation:

Moves Binance chain ID to network constants, renames a few BNB instances to BSC

@darkwing darkwing requested a review from a team as a code owner April 2, 2021 17:16
@darkwing darkwing requested a review from danjm April 2, 2021 17:16
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darkwing darkwing merged commit 284c2cb into MetaMask:develop Apr 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants