Update changelog headers and fix dates#10805
Merged
Conversation
6e76fe0 to
7c59774
Compare
Collaborator
Builds ready [7c59774]
Page Load Metrics (570 ± 43 ms)
|
The changelog release header format has been updated to match the "keep a changelog" [1] format. Each header is now the bracketed version number followed by a dash, then the release date in ISO-8601 format. The release dates in each header were also updated to match the date of the corresponding GitHub Release [2]. Many of these dates were incorrect because they were set on the day we created the release candidate, rather than on the day of release. Any changelog release entries without a corresponding GitHub release was left with the date already specified. The three oldest release headers were missing dates. For the first two, I used the date of the version bump commit. For the third, I removed it since no changes were listed anyway, and it represented a range of releases rather than a single one. The `auto-changelog.js` script has been updated to account for this new format as well. [1]: https://keepachangelog.com/en/1.0.0/ [2]: https://github.com/MetaMask/metamask-extension/releases
7c59774 to
45cfa63
Compare
darkwing
previously approved these changes
Apr 2, 2021
Collaborator
Builds ready [45cfa63]
Page Load Metrics (618 ± 46 ms)
|
Member
Author
|
Oops - the add a new release part didn't work after all! Fixed here: 27890c5 |
Collaborator
Builds ready [27890c5]
Page Load Metrics (560 ± 56 ms)
|
rekmarks
reviewed
Apr 2, 2021
| - [#7558](https://github.com/MetaMask/metamask-extension/pull/7558): Use localized messages for NotificationModal buttons | ||
|
|
||
| ## 7.7.0 Thu Nov 28 2019 [WITHDRAWN] | ||
| ## [7.7.0] - 2019-12-03 [WITHDRAWN] |
Member
|
@Gudahtt tangentially related: how do we plan to record the correct dates in the changelog going forward? |
Member
Author
|
That part isn't automated yet, but I had planned to have that be an automated post-release commit. |
rekmarks
approved these changes
Apr 2, 2021
Member
rekmarks
left a comment
There was a problem hiding this comment.
LGTM!
This must've been tedious. Thanks for doing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changelog release header format has been updated to match the "keep a changelog" format. Each header is now the bracketed version number followed by a dash, then the release date in ISO-8601 format.
The release dates in each header were also updated to match the date of the corresponding GitHub Release. Many of these dates were incorrect because they were set on the day we created the release candidate, rather than on the day of release.
Any changelog release entries without a corresponding GitHub release was left with the date already specified.
The three oldest release headers were missing dates. For the first two, I used the date of the version bump commit. For the third, I removed it since no changes were listed anyway, and it represented a range of releases rather than a single one.
The
auto-changelog.jsscript has been updated to account for this new format as well.Manual testing steps:
For RC changelog updates with existing release header:
versioninapp/manifest/_base.json, to simulate an RC-like environmentyarn update-changelogFor updates without a release header:
versioninapp/manifest/_base.json, to simulate an RC-like environmentyarn update-changelog