Skip to content

Add changelog entries under release candidate header#10784

Merged
Gudahtt merged 2 commits intodevelopfrom
add-changelog-entries-under-correct-header
Apr 1, 2021
Merged

Add changelog entries under release candidate header#10784
Gudahtt merged 2 commits intodevelopfrom
add-changelog-entries-under-correct-header

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Mar 31, 2021

Instead of always placing new changelog entries under the "Current Develop Branch" header, the changelog script now places them under the header for the current release if that release has not yet been tagged.

This eliminates one manual step from the release process.

Relates to #10752

Manual testing steps :

For development changelog updates:

  • Run yarn update-changelog
  • See that it places changelog entries under 'Current Develop Branch'

For RC changelog updates:

  • Bump the version in app/manifest/_base.json, to simulate an RC-like environment
  • Add a new release header to the changelog for the new version
  • Run yarn update-changelog
  • See that it places changelog entries under the new release header

For updates without a release header:

  • Bump the version in app/manifest/_base.json, to simulate an RC-like environment
  • Run yarn update-changelog
  • See that it throws an error because it cannot find the release header

For testing that it doesn't confuse v10.0.0 and v10.0.0-prefix:

  • Bump the version in app/manifest/_base.json to v10.0.0, to simulate an RC-like environment
  • Add a header to the changelog for v10.0.0-beta.0
  • Run yarn update-changelog
  • See that it throws an error because it cannot find the release header, showing that it doesn't confuse v10.0.0 for v10.0.0-beta.0

Instead of always placing new changelog entries under the "Current
Develop Branch" header, the changelog script now places them under the
header for the current release if that release has not yet been tagged.

This eliminates one manual step from the release process.

Relates to #10752
@Gudahtt Gudahtt requested review from a team and kumavis as code owners March 31, 2021 17:17
@Gudahtt Gudahtt requested a review from darkwing March 31, 2021 17:17
@metamaskbot
Copy link
Collaborator

Builds ready [56b208a]
Page Load Metrics (585 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint458659105
domContentLoaded3626845849345
load3646855859345
domInteractive3626835839345

@metamaskbot
Copy link
Collaborator

Builds ready [2c16d52]
Page Load Metrics (553 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46735894
domContentLoaded3866885519847
load3876895539747
domInteractive3866885519847

Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt merged commit dc75c18 into develop Apr 1, 2021
@Gudahtt Gudahtt deleted the add-changelog-entries-under-correct-header branch April 1, 2021 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants