Rewrite changelog script from Bash to JavaScript#10782
Merged
Conversation
Gudahtt
commented
Mar 31, 2021
9dd96b7 to
cd84643
Compare
The `auto-changelog` script has been rewritten from Bash to JavaScript. Functionally it should behave identically.
cd84643 to
b439050
Compare
Collaborator
Builds ready [b439050]
Page Load Metrics (677 ± 54 ms)
|
brad-decker
approved these changes
Mar 31, 2021
| * @param {Array<string>} [args] - The arguments to pass to the command | ||
| * @returns {Array<string>} Lines of output received via STDOUT | ||
| */ | ||
| async function runCommand(command, args) { |
Contributor
There was a problem hiding this comment.
this looks extremely robust. Well done.
| }); | ||
| } catch (error) { | ||
| /** | ||
| * The error is re-thrown here in an `async` context to preserve the stack trace. If this was |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
auto-changelogscript has been rewritten from Bash to JavaScript. Functionally it should behave identically.