Ensure correct primary currency image is displayed on home screen and token list#10777
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
0967454 to
89a4503
Compare
There was a problem hiding this comment.
Passing in the native currency as the "address" seems wrong 🤔 I see that we were already doing this for non-ETH native currencies though, for some reason 😕
There was a problem hiding this comment.
The effect of this, and perhaps this was the intent, is to have a jazzicon display when there is a custom symbol for the custom network. Like this:

If no symbol is provided, it looks like this.
I agree that we should not do this, and instead should just show the new default of Identicon: <div style={getStyles(diameter)}></div>;
Now, the only problem with changing this is if some users have become acustomed to seeing the jazzicon for their particular custom network... so I think it'd be best not to break that in this PR.
There was a problem hiding this comment.
Yeesh. So we're treating this as an address without validating that it's even remotely similar to an address. That's unfortunate.
Reminds me of this bug: #8252.
Leaving this alone for this PR seems sensible to me. I'm not sure we should be concerned about users being accustomed to this icon though. It seems very broken and confusing to me. Particularly because we use jazzicons for people, and we don't want tokens mistaken for people. Maybe we can discuss it in a future standup.
9238f31 to
7251d39
Compare
d293999 to
5e2ddab
Compare
f146afc to
f21361d
Compare
f21361d to
6cadd36
Compare

Explanation:
When on Binance Smart Chain, it's a bit jarring to see ETH as the default token image in the home header and token listing. This PR aims to fix that.
PrimaryIcon.mp4