Merged
Conversation
Collaborator
Builds ready [461fc3e]
Page Load Metrics (558 ± 46 ms)
|
461fc3e to
8b51f79
Compare
Collaborator
Builds ready [8b51f79]
Page Load Metrics (507 ± 48 ms)
|
rekmarks
approved these changes
Mar 30, 2021
Member
rekmarks
left a comment
There was a problem hiding this comment.
LGTM!
Should play well with our updated config, which includes a lot of these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Develop: 154.76s total. 31.1 seconds for prettier, 11.42 seconds for import/namespace, 48.82 seconds for the top mocha rules?
This PR:
Develop: 93.55s total. 11.36 seconds for prettier, 11.39 seconds for import/namespace, 17.18 seconds for the top mocha rules