Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [8c1439a]
Page Load Metrics (614 ± 42 ms)
|
…ork specific currency
8c1439a to
397cb5a
Compare
Collaborator
Builds ready [397cb5a]
Page Load Metrics (584 ± 50 ms)
|
darkwing
approved these changes
Mar 30, 2021
Contributor
darkwing
left a comment
There was a problem hiding this comment.
I can confirm that the BNB and ETH labels are displaying properly in both mainnet and BNB swaps!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses an issue found by @tmashuang while QAing v9.3.0
The
extraInfoRow.valueproperty passed from view-quote.js to the custom gas modal was using theamountInEthtranslation, meaning that the approve fee shown in the modal always had "ETH" as the currency symbol instead of the current networks symbol (e.g. BNB). This PR corrects that.After: