Ensure that priceSlippage fiat amounts are always shown in view-quote.js#10762
Merged
Ensure that priceSlippage fiat amounts are always shown in view-quote.js#10762
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [374020c]
Page Load Metrics (498 ± 51 ms)
|
374020c to
1fb4540
Compare
Collaborator
Builds ready [1fb4540]
Page Load Metrics (582 ± 41 ms)
|
darkwing
approved these changes
Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue found by @tmashuang when QAing v9.3.0: "Market Price unavailable" were always showing up on the second screen of the swaps flow while on the bsc network.
This is because
priceSlippageFromSourceandpriceSlippageFromDestinationwere always undefined, becauseuseEthFiatAmountreturns undefined if not on mainnet nor on a testnet while have set the "show fiat in testnet" setting to true.To ensure the calls to
useEthFiatAmountfromview-quote.jsbehave on other networks the same as they do on mainnet, this PR adds theoverrides.showFiatparameter to those calls.