Add New Zealand Dollar to currency options#10746
Merged
brad-decker merged 1 commit intoMetaMask:developfrom Mar 29, 2021
Merged
Add New Zealand Dollar to currency options#10746brad-decker merged 1 commit intoMetaMask:developfrom
brad-decker merged 1 commit intoMetaMask:developfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
brad-decker
approved these changes
Mar 29, 2021
Contributor
brad-decker
left a comment
There was a problem hiding this comment.
This LGTM! Thanks for the contribution @ScreamingHawk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: -
Explanation:
I was annoyed that I wasn't able to view my wallet balance in my own currency. Had a quick dig through the code and found that it's a simple fix to include it.
Double checked against the API that the currency is listed here: https://github.com/MetaMask/controllers/blob/develop/src/apis/crypto-compare.ts
If you are happy to accept this I can push the same change to the mobile repo as well.
Manual testing steps: