Skip to content

ci - cache deps before patch-package#10735

Merged
kumavis merged 2 commits intodevelopfrom
ci-fix-patch
Mar 26, 2021
Merged

ci - cache deps before patch-package#10735
kumavis merged 2 commits intodevelopfrom
ci-fix-patch

Conversation

@kumavis
Copy link
Member

@kumavis kumavis commented Mar 26, 2021

Fixes: #10734

we are accidentally caching the patched package and then patching them again

@kumavis kumavis requested a review from a team as a code owner March 26, 2021 03:11
@kumavis kumavis requested a review from ryanml March 26, 2021 03:11
EtDu
EtDu previously approved these changes Mar 26, 2021
Copy link
Contributor

@EtDu EtDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/sparkle

@EtDu
Copy link
Contributor

EtDu commented Mar 26, 2021

/sparkle @kumavis

@kumavis
Copy link
Member Author

kumavis commented Mar 26, 2021

cache is bad for branches that are sensitive to this bug

Copy link
Contributor

@EtDu EtDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new cache :)

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [ed37935]
Page Load Metrics (627 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint488662115
domContentLoaded35583262510752
load35683362710751
domInteractive35483262510752

@kumavis kumavis merged commit b668a90 into develop Mar 26, 2021
@kumavis kumavis deleted the ci-fix-patch branch March 26, 2021 03:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: CI - prep deps - we're caching the node_modules after patch

4 participants