Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
previously approved these changes
Mar 25, 2021
shared/constants/swaps.js
Outdated
| // An address that the metaswap-api recognizes as ETH, in place of the token address that ERC-20 tokens have | ||
| const ETH_SWAPS_TOKEN_ADDRESS = '0x0000000000000000000000000000000000000000'; | ||
|
|
||
| const BNB_SWAPS_TOKEN_ADDRESS = '0x0000000000000000000000000000000000000000'; |
Member
There was a problem hiding this comment.
Nit: Maybe instead of adding an additional constant, we could rename the old one to no longer imply that it's network-specific? It doesn't seem network-specific.
Collaborator
Builds ready [2ee4589]
Page Load Metrics (600 ± 11 ms)
|
Gudahtt
approved these changes
Mar 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps now works on another network.