build - refactor build system for easier configuration#10718
Merged
build - refactor build system for easier configuration#10718
Conversation
Collaborator
Builds ready [f9e8640]
Page Load Metrics (588 ± 20 ms)
|
Collaborator
Builds ready [195d4d6]
Page Load Metrics (641 ± 19 ms)
|
ryanml
previously approved these changes
Mar 26, 2021
Contributor
There was a problem hiding this comment.
Looks good to me! Steps I ran through to test
- Ran
yarn setupon a fresh build from this branch - Built prod by running
yarn dist - Confirmed after sideloading the extension that there no were no
background.jsor client errors, and that account creation worked fine. - Ran
rm -rf dist/ - Built dev by running
yarn start - Confirmed after sideloading the extension that there no were no
background.jsor client errors, and that account creation worked fine. - Confirmed that both changes to
.js. and.scssfiles reloaded the extension appropriately.
One nit: perhaps lets tie this to a dev issue just for tracking purposes
5 tasks
Gudahtt
reviewed
Mar 26, 2021
Gudahtt
reviewed
Mar 26, 2021
Gudahtt
reviewed
Mar 26, 2021
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Member
Author
|
thanks. what are types anyways. |
Gudahtt
approved these changes
Mar 26, 2021
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM!
I did confirm that after a rebase, this didn't result in any changes to the output of yarn dist. Also everything seems to work as it did before - yarn dist failures result in a non-zero exit code, yarn start is tolerant of failure, etc.
Collaborator
Builds ready [374f8c0]
Page Load Metrics (632 ± 20 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bringing this refactor back to life #8170
this time without the factoring/libs changes
this should cause no change to the output bundle