fix: remove unused metamask.rpcUrl from redux state + fix tests to reflect that#10714
Merged
shanejonas merged 1 commit intodevelopfrom Mar 24, 2021
Merged
fix: remove unused metamask.rpcUrl from redux state + fix tests to reflect that#10714shanejonas merged 1 commit intodevelopfrom
metamask.rpcUrl from redux state + fix tests to reflect that#10714shanejonas merged 1 commit intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Member
|
I think this line can be removed as well: https://github.com/MetaMask/metamask-extension/blob/develop/ui/app/ducks/metamask/metamask.js#L10 |
202ae94 to
ca184d1
Compare
Collaborator
Builds ready [ca184d1]
Page Load Metrics (594 ± 14 ms)
|
Member
|
Found one more! https://github.com/MetaMask/metamask-extension/blob/develop/.storybook/test-data.js#L8 I looked at every other instance of |
ca184d1 to
40e2c67
Compare
Collaborator
Builds ready [40e2c67]
Page Load Metrics (605 ± 12 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation:
metamask.rpcUrlis unused