rule out empty string for symbol#10712
Merged
brad-decker merged 1 commit intodevelopfrom Mar 24, 2021
Merged
Conversation
Collaborator
Builds ready [913b0b3]
Page Load Metrics (640 ± 27 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10705
It's possible for the token symbol to be an empty string on some tokens, this change simply makes it so that the approve confirmation loads when there is an empty string. Credit to @danjm for pointing out the fix and @tmashuang for identifying easy reproduction steps.