Conversation
ui/app/pages/keychains/index.scss
Outdated
There was a problem hiding this comment.
There was no rule defined at all for import-account__input-label. (this is in line with the other text label styling)
|
cc: @danfinlay just to confirm updated copy looks fine |
Builds ready [63f685b]
Page Load Metrics (623 ± 12 ms)
|
brad-decker
left a comment
There was a problem hiding this comment.
LGTM other than that translation issue. Lets bring this up in the extension sync today.
app/_locales/en/messages.json
Outdated
There was a problem hiding this comment.
With this change (and importYourExisting) we'll want to make sure our other language files get updated to reflect the difference as well. I still don't know what's the best practice here, if we can just resubmit this file for translation of the keys that have been updated or what.
There was a problem hiding this comment.
The best approach we have is to remove the translations and hope somebody re-adds them. Not a great process, but, hopefully we'll have a better one soon for some locales at least.
There was a problem hiding this comment.
As discussed on sync, taking the approach @Gudahtt mentioned for now, translations updated
Adding translation entry for "Wallet Seed" Fixed label padding issue by adding missing CSS rule
Builds ready [39fd8cf]
Page Load Metrics (675 ± 37 ms)
|
Fixes: #10604
Screens with updated copy
Padding fix
Before
After
