Skip to content

Fix 10562 - Hide the suggested token pane when not on Mainnet or test network#10702

Merged
darkwing merged 3 commits intoMetaMask:developfrom
darkwing:10562-suggested-tokens
Mar 25, 2021
Merged

Fix 10562 - Hide the suggested token pane when not on Mainnet or test network#10702
darkwing merged 3 commits intoMetaMask:developfrom
darkwing:10562-suggested-tokens

Conversation

@darkwing
Copy link
Contributor

Fixes: #10562

Explanation:

When a user clicks "Add Token", we don't want to show the token search pane if the user isn't on Ethereum Main Net or a known test network.

Manual testing steps:

  • Set the network to Ethereum main net
  • Click "Add token -- you will see the search tab and it will be functional
  • Set the network to a custom network
  • Click "Add token -- you will not see the search tab
NoSearch.mp4

@darkwing darkwing requested a review from a team as a code owner March 23, 2021 21:05
@darkwing darkwing requested a review from NiranjanaBinoy March 23, 2021 21:05
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Gudahtt
Gudahtt previously approved these changes Mar 25, 2021
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One minor suggestion

@darkwing darkwing merged commit d4842b0 into MetaMask:develop Mar 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not show suggested token list in add token on custom networks

3 participants