Skip to content

Update @metamask/controllers to v6.2.1#10701

Merged
danjm merged 1 commit intodevelopfrom
update-metamask-controllers-v6.2.0
Mar 25, 2021
Merged

Update @metamask/controllers to v6.2.1#10701
danjm merged 1 commit intodevelopfrom
update-metamask-controllers-v6.2.0

Conversation

@danjm
Copy link
Contributor

@danjm danjm commented Mar 23, 2021

This PR updates the version of @metamask/controllers to v6.2.1

It includes changes to the use of the approval controller, for which there was a breaking change in v6.0.0. This change was made with MetaMask/core#321

@danjm danjm requested a review from a team as a code owner March 23, 2021 19:38
@danjm danjm requested a review from Gudahtt March 23, 2021 19:38
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [abe1602]
Page Load Metrics (700 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46816294
domContentLoaded6058316995727
load6058327005727
domInteractive6048316985627

@danjm danjm force-pushed the update-metamask-controllers-v6.2.0 branch from abe1602 to 7094784 Compare March 23, 2021 23:54
@danjm danjm changed the title Update @metamask/controllers to v6.2.0 Update @metamask/controllers to v6.2.1 Mar 23, 2021
@metamaskbot
Copy link
Collaborator

Builds ready [7094784]
Page Load Metrics (594 ± 16 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint438559136
domContentLoaded5587095923316
load5587105943316
domInteractive5577095923316

@danjm danjm force-pushed the update-metamask-controllers-v6.2.0 branch from 7094784 to 755c462 Compare March 24, 2021 02:43
@metamaskbot
Copy link
Collaborator

Builds ready [755c462]
Page Load Metrics (701 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint51796494
domContentLoaded5968767007134
load5978787017134
domInteractive5968766997134

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danjm danjm merged commit 9573aa7 into develop Mar 25, 2021
@danjm danjm deleted the update-metamask-controllers-v6.2.0 branch March 25, 2021 20:07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants