Skip to content

Delete setupFetchDebugging.js#10636

Merged
kumavis merged 2 commits intodevelopfrom
rm-fetch-debugging
Mar 23, 2021
Merged

Delete setupFetchDebugging.js#10636
kumavis merged 2 commits intodevelopfrom
rm-fetch-debugging

Conversation

@kumavis
Copy link
Member

@kumavis kumavis commented Mar 12, 2021

Fixes #10635

@kumavis kumavis requested a review from a team as a code owner March 12, 2021 05:14
@kumavis kumavis requested a review from Gudahtt March 12, 2021 05:14
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are still references to this in background.js: https://github.com/MetaMask/metamask-extension/blob/develop/app/scripts/background.js#L6-L9

@kumavis
Copy link
Member Author

kumavis commented Mar 23, 2021

whoops yeah that was quite sloppy. made the pr in github ui 🤡

@metamaskbot
Copy link
Collaborator

Builds ready [6f905b3]
Page Load Metrics (652 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint49836094
domContentLoaded4467566516732
load4487576526732
domInteractive4467566506732

@kumavis
Copy link
Member Author

kumavis commented Mar 23, 2021

ready for you @ryanml

Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kumavis kumavis merged commit bfdc1e6 into develop Mar 23, 2021
@kumavis kumavis deleted the rm-fetch-debugging branch March 23, 2021 10:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review Fetch Debugging

3 participants