Skip to content

Move the METASWAP_API_HOST constant to the swaps constant file#10612

Merged
danjm merged 1 commit intodevelopfrom
move-swaps-api-constant
Mar 9, 2021
Merged

Move the METASWAP_API_HOST constant to the swaps constant file#10612
danjm merged 1 commit intodevelopfrom
move-swaps-api-constant

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented Mar 9, 2021

This groups the constant with other swaps constants, and is a step towards some other reorganization work we need to do, in order to more cleanly support other networks (like our testnet).

@danjm danjm requested a review from a team as a code owner March 9, 2021 09:37
@danjm danjm requested a review from ryanml March 9, 2021 09:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 9, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm force-pushed the move-swaps-api-constant branch from 322053a to 39c3379 Compare March 9, 2021 09:38
@danjm danjm force-pushed the move-swaps-api-constant branch from 39c3379 to 8a1ee87 Compare March 9, 2021 09:38
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [8a1ee87]
Page Load Metrics (600 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded3317995988641
load3338006008641
domInteractive3317995988641

@danjm danjm merged commit 21868e0 into develop Mar 9, 2021
@danjm danjm deleted the move-swaps-api-constant branch March 9, 2021 16:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants