Skip to content

Unifies unit tests filename suffix to .test.js#10607

Merged
tmashuang merged 5 commits intodevelopfrom
unify-test-filenames
Mar 9, 2021
Merged

Unifies unit tests filename suffix to .test.js#10607
tmashuang merged 5 commits intodevelopfrom
unify-test-filenames

Conversation

@tmashuang
Copy link
Copy Markdown
Contributor

@tmashuang tmashuang commented Mar 8, 2021

Unifies the unit tests to a .test.js filename extension suffix.

@tmashuang tmashuang requested a review from a team as a code owner March 8, 2021 21:09
@tmashuang tmashuang requested a review from shanejonas March 8, 2021 21:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 8, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tmashuang tmashuang force-pushed the unify-test-filenames branch from b871a62 to 3aed7a8 Compare March 8, 2021 21:11
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [3aed7a8]
Page Load Metrics (572 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint47805984
domContentLoaded34573557110450
load34673657210450
domInteractive34573557110450

@tmashuang tmashuang changed the title Unifies the filename suffix to .test.js Unifies unit tests filename suffix to .test.js Mar 9, 2021
darkwing
darkwing previously approved these changes Mar 9, 2021
Copy link
Copy Markdown
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, I love this @tmashuang

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [72e9be1]
Page Load Metrics (569 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint49695763
domContentLoaded3436405678541
load3456415698541
domInteractive3436405678541

@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Mar 9, 2021

I tried looking for files with test in the name, and found a few missing from this PR:

/test/unit/app/controllers/transactions/tx-helper-test.js
./test/unit/app/controllers/transactions/tx-gas-util-test.js
./test/unit/app/controllers/transactions/pending-tx-tracker-test.js
./test/unit/app/controllers/transactions/tx-state-history-helpers-test.js
./test/unit/app/controllers/transactions/tx-utils-test.js
./test/unit/app/controllers/transactions/tx-state-manager-test.js
./test/unit/app/controllers/transactions/tx-controller-test.js

I also found a few remaining with the spec.js suffix:

/test/unit/ui/app/actions.spec.js
./test/unit/ui/app/reducers/metamask.spec.js
./test/unit/ui/app/reducers/app.spec.js
./test/unit/ui/etherscan-prefix-for-network.spec.js

@tmashuang
Copy link
Copy Markdown
Contributor Author

tmashuang commented Mar 9, 2021

./test/unit/ui/etherscan-prefix-for-network.spec.js does not show up in my directory list, I believe it was removed in #10580. I've rebased with develop since this was off of a long running branch that might have been the case.

@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Mar 9, 2021

Oh, found one more!

./test/unit-global/frozenPromise.js

That's all I can find though. I just finished manually scanning the test directory.

Gudahtt
Gudahtt previously approved these changes Mar 9, 2021
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [97b0d06]
Page Load Metrics (582 ± 9 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44735684
domContentLoaded559635580199
load561636582199
domInteractive559634580199

@tmashuang tmashuang merged commit 3ba91df into develop Mar 9, 2021
@tmashuang tmashuang deleted the unify-test-filenames branch March 9, 2021 19:08
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants