You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Explanation:
Removes proper noun 'Ethereum' from the translation strings. Going to need help verifying all locales. Note that I did not remove anything from the ko translation because the word Ethereum did not appear in the string.
Gudahtt
changed the title
remove proper noun Ethereum from all locales for onlyAddTrustedNetwroks
remove proper noun Ethereum from all locales for onlyAddTrustedNetworks
Mar 5, 2021
The reason will be displayed to describe this comment to others. Learn more.
We might want to consider removing some or all of these translations. We might be making them confusing/grammatically incorrect by removing this term.
Also some of them still seem to include translations of Ethereum. The ko message still includes 'Ethereum' in the output when translated with Google Translate for example.
That's essentially what we've done in most other cases where the meaning of the message has changed. Deleting them seems appropriate. If there were any where you felt reasonable confident the sentences still makes sense without 'Ethereum' we could make exceptions though.
In the end I removed a handful of translations that just didn't seem correct or to match the original intent of the message, and kept a few. I removed the Korean translation as it included the word Ethereum in it, so we'll need a new translation for that locale. The same goes for the simplified Chinese.
I removed Japanese and Filipino translations because the google translate seemed off to me and I want to ensure we get accurate translations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10388
Explanation:
Removes proper noun 'Ethereum' from the translation strings. Going to need help verifying all locales. Note that I did not remove anything from the
kotranslation because the wordEthereumdid not appear in the string.