Fix mobile sync filtering of ERC20 tokens#10591
Merged
Conversation
In #10510 we changed how tokens are stored, keying them by `chainId` rather than network type. However we didn't update our mobile sync function to account for this, which ended up breaking the filtering logic used to prepare the data that is synced. Specifically, custom tokens added by users are filtered out to just those that are confirmed to be ERC20 tokens in our built-in list of tokens. This filters out unrecognized tokens and NFTs. The filtering logic has been restored to the pre-#10510 behaviour.
Collaborator
Builds ready [72a1d88]
Page Load Metrics (587 ± 33 ms)
|
brad-decker
approved these changes
Mar 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #10510 we changed how tokens are stored, keying them by
chainIdrather than network type. However we didn't update our mobile sync function to account for this, which ended up breaking the filtering logic used to prepare the data that is synced.Specifically, custom tokens added by users are filtered out to just those that are confirmed to be ERC20 tokens in our built-in list of tokens. This filters out unrecognized tokens and NFTs.
The filtering logic has been restored to the pre-#10510 behaviour. The tokens remain keyed by
chainIdthough, which is different from pre-v9.1.0