use etherscan-link for account-link#10590
Merged
brad-decker merged 1 commit intodevelopfrom Mar 10, 2021
Merged
Conversation
96b65bd to
cfd4317
Compare
Collaborator
Builds ready [cfd4317]
Page Load Metrics (567 ± 40 ms)
|
cfd4317 to
593722d
Compare
Collaborator
Builds ready [593722d]
Page Load Metrics (659 ± 19 ms)
|
danjm
approved these changes
Mar 10, 2021
Contributor
danjm
left a comment
There was a problem hiding this comment.
Code looks good. QA'd each instance on the etherscan link updated in the PR, all looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
progresses #8668
Explanation: use new method to get link by chainId instead of network, and remove duplicated code that now exists in MetaMask/etherscan-link. This also makes sure to get rpcPrefs everywhere that we ask for this.
requires MetaMask/etherscan-link#32