prefer chainId when building block explorer urls#10587
Merged
brad-decker merged 1 commit intodevelopfrom Mar 9, 2021
Merged
Conversation
705c2ab to
7384473
Compare
Collaborator
Builds ready [7384473]
Page Load Metrics (560 ± 38 ms)
|
b4c9e44 to
cb605e5
Compare
Contributor
Author
|
|
cb605e5 to
18f231e
Compare
Collaborator
Builds ready [18f231e]
Page Load Metrics (550 ± 42 ms)
|
18f231e to
cd23b1e
Compare
Collaborator
Builds ready [cd23b1e]
Page Load Metrics (701 ± 47 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progresses #8668, #7864, #10041
For the last two, #7864 and #10041 -- more work is needed to completely resolve this but @BboyAkers has inflight work that will help. This PR doesn't change how we are generating custom block explorer URLs.
Relies on MetaMask/etherscan-link#32Details:
blockExplorerUrlthat prefers thechainIdparameter of a transaction, but falls back tometamaskNetworkIdmetamaskNetworkIdnetworkId/rpcPrefswere being pulled from redux usinguseSelectorbut then were only being passed intoAwaitingSwap. Moved those selectors directly intoAwaitingSwapblockExplorerUrl, removednetworkIdin favor ofchainId.metamaskNetworkIdof theprimaryTransaction. I realize it is unlikely, perhaps impossible, for themetamaskNetworkIdto differ from one transaction in a group to another but it caused me some confusion so I opted to clean this up and addmetamaskNetworkIdandchainIdto the activity object.showTransactionNotificationso that we can link custom network notifications properly.