Skip to content

Remove dead code related to the selectedFromToken variable in swaps/index.js#10570

Merged
danjm merged 1 commit intodevelopfrom
remove-selectedFromToken-swaps-index
Mar 3, 2021
Merged

Remove dead code related to the selectedFromToken variable in swaps/index.js#10570
danjm merged 1 commit intodevelopfrom
remove-selectedFromToken-swaps-index

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented Mar 3, 2021

This PR removes some unused code. It was all needed for the selectedFromToken passed to the BuildQuote component, but BuildQuote doesn't accept / make use of a selectedFromToken prop.

@danjm danjm requested a review from a team as a code owner March 3, 2021 14:39
@danjm danjm requested a review from shanejonas March 3, 2021 14:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [14ed382]
Page Load Metrics (632 ± 19 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46765994
domContentLoaded5787406303919
load5797416323919
domInteractive5787396303919

@danjm danjm merged commit 325215f into develop Mar 3, 2021
@danjm danjm deleted the remove-selectedFromToken-swaps-index branch March 3, 2021 15:46
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants