Convert useSwapsEthToken hook to a selector#10568
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [b549c27]
Page Load Metrics (590 ± 31 ms)
|
brad-decker
suggested changes
Mar 3, 2021
Contributor
brad-decker
left a comment
There was a problem hiding this comment.
Is the hook file still being used after this? it doesn't appear to be removed in this PR.
| checksumAddress, | ||
| getAccountByAddress, | ||
| } from '../helpers/utils/util'; | ||
| import { |
Contributor
There was a problem hiding this comment.
Review note: this is just the code from the hook, now as a selector, it doesn't appear to be modified except in name, and that it is now a selector that expects state as an argument.
| * in regular ERC-20 token objects, per the above description. | ||
| * | ||
| * @returns {SwapsEthToken} The token object representation of the currently | ||
| * selected account's ETH balance, as expected by the Swaps API. |
Contributor
There was a problem hiding this comment.
This doc block now should probably have a @param given it expects state.
Contributor
Author
|
@brad-decker your comments are addressed in the latest commit |
Collaborator
Builds ready [e9dd87a]
Page Load Metrics (609 ± 41 ms)
|
brad-decker
approved these changes
Mar 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
useSwapsEthTokendoes not need to be a hook, as it does not rely on other hooks (with the exception of useSelector, the need for which can just be met with a selector). It can be simplified to being a selector. This will also make it easier to use in more contexts (as it won't need to follow the rules of hooks)