Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
brad-decker
suggested changes
Mar 2, 2021
| <h1 className="error-page__header">{t('errorPageTitle')}</h1> | ||
| <h2 className="error-page__subheader"> | ||
| {isPopup ? t('errorPagePopupMessage') : t('errorPageMessage')} | ||
| {t(messageKey, [this.renderHelpLink()])} |
Contributor
There was a problem hiding this comment.
[REQ] I don't see the harm in rendering the tag inline here instead of extracting to a render function. We won't have this option of separating out parts of our JSX without creating intermediary components in files that follow our new paradigms (functional components).
Contributor
Author
There was a problem hiding this comment.
Makes sense, force of habit was at work here :)
| </div> | ||
| <div className="end-of-flow__text-3"> | ||
| {`• ${t('endOfFlowMessage7')}`} | ||
| • {t('endOfFlowMessage7', [this.renderHelpLink()])} |
Gudahtt
reviewed
Mar 2, 2021
Gudahtt
reviewed
Mar 2, 2021
Collaborator
Builds ready [8e8391b]
Page Load Metrics (736 ± 28 ms)
|
Collaborator
Builds ready [dcd9add]
Page Load Metrics (547 ± 21 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10188
Also removes the
UniqueImagecomponent, as it was no longer being used. It was part of the scope of the support email replacement.