Adding a warning when sending a token to its own contract address#10546
Adding a warning when sending a token to its own contract address#10546
Conversation
|
CLA Signature Action: Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:
By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository. 0 out of 1 committers have signed the CLA.
|
|
running yarn lint:fix will organize the messages file alphabetically, but other than lint failure this looks good to me. Obviously, three alerts here is a bit much, but it's a temporary holdover until we implement the new designs. |
ui/app/pages/send/send.component.js
Outdated
There was a problem hiding this comment.
I noticed a bug here with the "Known Contract Address" warning that also presented itself for the new error. It seems these messages are not intended to show when ETH is the selected asset, however, when switching back to ETH from an ERC-20 token, the messages don't clear properly. The validate method of this component does not trigger when selecting a new send asset
Builds ready [a294423]
Page Load Metrics (617 ± 21 ms)
|
Fixes #9437
Manual testing steps:
0x514910771af9ca656af840dff83e8264ecf986ca(LINK contract address)