Skip to content

Make Lavamoat optional for dev mode#10538

Merged
kumavis merged 1 commit intodevelopfrom
optional-lavamoat
Mar 3, 2021
Merged

Make Lavamoat optional for dev mode#10538
kumavis merged 1 commit intodevelopfrom
optional-lavamoat

Conversation

@EtDu
Copy link
Copy Markdown
Contributor

@EtDu EtDu commented Mar 1, 2021

No description provided.

@EtDu EtDu requested a review from a team as a code owner March 1, 2021 06:06
@EtDu EtDu requested a review from darkwing March 1, 2021 06:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 1, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [4e9baec]
Page Load Metrics (641 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint48756194
domContentLoaded5528536397536
load5538546417536
domInteractive5528536397536

Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@kumavis kumavis merged commit 3128d18 into develop Mar 3, 2021
@kumavis kumavis deleted the optional-lavamoat branch March 3, 2021 07:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2021
@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Mar 3, 2021

The sub-tasks still run using lavamoat, because they're run with yarn build

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants