Skip to content

add trezor HD path for ledger wallets#10532

Closed
bgits wants to merge 0 commit intoMetaMask:developfrom
bgits:develop
Closed

add trezor HD path for ledger wallets#10532
bgits wants to merge 0 commit intoMetaMask:developfrom
bgits:develop

Conversation

@bgits
Copy link
Contributor

@bgits bgits commented Feb 27, 2021

Fixes: #10531

Explanation:

Allows Trezor users to access their accounts from a Ledger

Manual testing steps:

  1. Load Trezor from mnemonic.
  2. Load Ledger from mnemonic.
  3. Connect to Trezor in Metamask and note the first 10 accounts.
  4. Connect to Ledger in Metamask using Trezor from dropdown for HD path.

User should be able to access all accounts they had on Trezor from their ledger.

@bgits bgits requested a review from a team as a code owner February 27, 2021 21:10
@bgits bgits requested a review from Gudahtt February 27, 2021 21:10
@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bgits
Copy link
Contributor Author

bgits commented Feb 27, 2021

I have read the CLA Document and I hereby sign the CLA

@darkwing
Copy link
Contributor

darkwing commented Mar 3, 2021

Thank you for this contribution, @bgits ! I'll be be diving in very soon!

@Gudahtt Gudahtt closed this Mar 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2021
@Gudahtt
Copy link
Member

Gudahtt commented Mar 9, 2021

🤦 I accidentally closed this by pushing the wrong commit. My apologies. I rebased it locally but then pushed develop instead of HEAD... should have pushed HEAD:develop instead of develop.

@MetaMask MetaMask unlocked this conversation Mar 9, 2021
@Gudahtt
Copy link
Member

Gudahtt commented Mar 9, 2021

Replacement PR here: #10616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ledger does not support Trezor HD path

3 participants